Reorder grid states #1037
Merged
Reorder grid states #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erri120
added
the
Epic: Workspace System
Al12rs
reviewed
Mar 6, 2024
Horizontal
|
Vertical
|
|
That looks good to me, Great work! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
- Coverage 56.55% 56.55% -0.01%
==========================================
Files 648 648
Lines 21354 21360 +6
Branches 1664 1664
==========================================
+ Hits 12077 12080 +3
- Misses 8879 8882 +3
Partials 398 398
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Al12rs
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #906.
Fixes the order in which the possible grid states are generated. Now, we prioritize and put the primary action first, rather than last, depending on the orientation.