Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link mod pages #1034

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 6, 2024

Resolves #1028.

  • Adds ISMAPIWebApi for interacting with the SMAPI Web API
  • Updates existing diagnostics with links to mod pages
@erri120 erri120 added this to the v0.4 milestone Mar 6, 2024
@erri120 erri120 requested a review from a team March 6, 2024 11:51
@erri120 erri120 self-assigned this Mar 6, 2024
@erri120 erri120 changed the title Feat/1028 missing smapi mod link Mar 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0.66225% with 150 lines in your changes are missing coverage. Please review.

Project coverage is 55.62%. Comparing base (75c3c2e) to head (222abf3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
- Coverage   56.55%   55.62%   -0.94%     
==========================================
  Files         648      649       +1     
  Lines       21354    21485     +131     
  Branches     1664     1670       +6     
==========================================
- Hits        12077    11950     -127     
- Misses       8879     9133     +254     
- Partials      398      402       +4     
Flag Coverage Δ
Linux 55.53% <0.66%> (-0.33%) ⬇️
Windows ?
clean_environment_tests 55.61% <0.66%> (-0.93%) ⬇️
macOS 54.92% <0.66%> (-0.35%) ⬇️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/Games/NexusMods.Games.StardewValley/Services.cs 100.00% <100.00%> (ø)
...Games/NexusMods.Games.StardewValley/Diagnostics.cs 0.00% <0.00%> (ø)
...rdewValley/Emitters/DependencyDiagnosticEmitter.cs 0.00% <0.00%> (ø)
...exusMods.Games.StardewValley/WebAPI/SMAPIWebApi.cs 0.00% <0.00%> (ø)

... and 29 files with indirect coverage changes

@erri120 erri120 force-pushed the feat/1028-missing-smapi-mod-link branch from becbcf5 to 4e19ee4 Compare March 7, 2024 09:34
@erri120 erri120 requested a review from Al12rs March 7, 2024 09:35
@Al12rs
Copy link
Contributor

Al12rs commented Mar 7, 2024

Restarting the CI, was giving an error, maybe check locally in the meantime

@Al12rs Al12rs self-requested a review March 7, 2024 09:53
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failing:

/home/runner/work/NexusMods.App/NexusMods.App/src/Games/NexusMods.Games.StardewValley/WebAPI/SMAPIWebApi.cs(85,53): error CS8619: Nullability of reference types in value of type '(string?, Uri?)' doesn't match target type '(string id, Uri uri)'. 

Edit: Ah, you beat me to it

@erri120 erri120 merged commit 9fdd3b8 into Nexus-Mods:main Mar 7, 2024
7 checks passed
@erri120 erri120 deleted the feat/1028-missing-smapi-mod-link branch March 7, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants