-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link mod pages #1034
Link mod pages #1034
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
- Coverage 56.55% 55.62% -0.94%
==========================================
Files 648 649 +1
Lines 21354 21485 +131
Branches 1664 1670 +6
==========================================
- Hits 12077 11950 -127
- Misses 8879 9133 +254
- Partials 398 402 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
becbcf5
to
4e19ee4
Compare
Restarting the CI, was giving an error, maybe check locally in the meantime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failing:
/home/runner/work/NexusMods.App/NexusMods.App/src/Games/NexusMods.Games.StardewValley/WebAPI/SMAPIWebApi.cs(85,53): error CS8619: Nullability of reference types in value of type '(string?, Uri?)' doesn't match target type '(string id, Uri uri)'.
Edit: Ah, you beat me to it
Resolves #1028.
ISMAPIWebApi
for interacting with the SMAPI Web API