Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract SMAPI version #1033

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Extract SMAPI version #1033

merged 2 commits into from
Mar 6, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 6, 2024

Resolves #1027.
@erri120 erri120 added this to the v0.4 milestone Mar 6, 2024
@erri120 erri120 requested a review from a team March 6, 2024 10:29
@erri120 erri120 self-assigned this Mar 6, 2024
Al12rs
Al12rs approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't particularly like the fact that we need to extract the file after we just packaged it, but I don't know if we can do any better right now.
@erri120
Copy link
Member Author

erri120 commented Mar 6, 2024

I don't particularly like the fact that we need to extract the file after we just packaged it, but I don't know if we can do any better right now.

If we have a custom version parser for managed assemblies, we wouldn't need to extract the file from the archive. However, we currently use FileVersionInfo from .NET which requires an actual file on disk.
@erri120 erri120 merged commit 75c3c2e into Nexus-Mods:main Mar 6, 2024
6 checks passed
@erri120 erri120 deleted the feat/1027-smapi-version branch March 6, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@erri120 @Al12rs