Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic for missing SMAPI #1026

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 5, 2024

No description provided.

@erri120 erri120 added this to the v0.4 milestone Mar 5, 2024
@erri120 erri120 requested a review from a team March 5, 2024 11:31
@erri120 erri120 self-assigned this Mar 5, 2024
@erri120 erri120 requested a review from Al12rs March 5, 2024 13:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 5.55556% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 56.67%. Comparing base (5a7f934) to head (bc49239).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   56.09%   56.67%   +0.57%     
==========================================
  Files         645      648       +3     
  Lines       21259    21311      +52     
  Branches     1657     1661       +4     
==========================================
+ Hits        11926    12077     +151     
+ Misses       8931     8836      -95     
+ Partials      402      398       -4     
Flag Coverage Δ
Linux 55.98% <5.55%> (-0.11%) ⬇️
Windows 55.90% <5.55%> (∅)
clean_environment_tests 56.65% <5.55%> (+0.55%) ⬆️
macOS 55.39% <5.55%> (?)
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/Games/NexusMods.Games.StardewValley/Services.cs 100.00% <100.00%> (ø)
.../Games/NexusMods.Games.StardewValley/TypeFinder.cs 100.00% <100.00%> (ø)
...ames.StardewValley/Installers/SMAPIModInstaller.cs 0.00% <0.00%> (ø)
...exusMods.Games.StardewValley/Models/SMAPIMarker.cs 0.00% <0.00%> (ø)
...sMods.Games.StardewValley/Models/SMAPIModMarker.cs 0.00% <0.00%> (ø)
...s.Games.StardewValley/Installers/SMAPIInstaller.cs 0.00% <0.00%> (ø)
...Games/NexusMods.Games.StardewValley/Diagnostics.cs 0.00% <0.00%> (ø)
...ames.StardewValley/Emitters/MissingSMAPIEmitter.cs 0.00% <0.00%> (ø)

... and 35 files with indirect coverage changes

@Al12rs Al12rs merged commit 770341a into Nexus-Mods:main Mar 5, 2024
6 checks passed
@erri120 erri120 deleted the feat/missing-smapi branch March 6, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants