Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installers to set mod metadata #1020

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 4, 2024

Resolves #1018.

@erri120 erri120 requested a review from a team March 4, 2024 11:19
@erri120 erri120 self-assigned this Mar 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 56.80%. Comparing base (3c9e15b) to head (247dc1a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   56.06%   56.80%   +0.73%     
==========================================
  Files         645      645              
  Lines       21244    21248       +4     
  Branches     1655     1656       +1     
==========================================
+ Hits        11910    12069     +159     
+ Misses       8941     8783     -158     
- Partials      393      396       +3     
Flag Coverage Δ
Linux 56.08% <58.33%> (?)
Windows 56.04% <58.33%> (+0.06%) ⬆️
clean_environment_tests 56.78% <58.33%> (+0.72%) ⬆️
macOS 55.49% <58.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Mods.Abstractions.Installers/ModInstallerResult.cs 85.71% <100.00%> (+2.38%) ⬆️
...ctions/NexusMods.Abstractions.Loadouts/Mods/Mod.cs 100.00% <100.00%> (ø)
src/NexusMods.DataModel/ArchiveInstaller.cs 69.33% <50.00%> (-0.74%) ⬇️

... and 21 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Mar 4, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@erri120 erri120 merged commit ec39298 into Nexus-Mods:main Mar 4, 2024
6 checks passed
@erri120 erri120 deleted the feat/1018-mod-metadata branch March 4, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants