Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project code style file #1019

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Mar 4, 2024

No description provided.

@erri120 erri120 added the Epic: Tech-debt Technical debt, this needs solving in the long-term label Mar 4, 2024
@erri120 erri120 requested a review from a team March 4, 2024 10:43
<component name="ProjectCodeStyleConfiguration">
<code_scheme name="Project" version="173">
<option name="LINE_SEPARATOR" value="&#10;" />
<option name="RIGHT_MARGIN" value="1000" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I object to 1000 here, if left to developer discretion lines are unlikely to be kept under 120 characters (which I would like for GitHub readability).
I do not wish to tell people to shorten their lines in PR review, this should be handled by the formatter.

Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per Halgari ruling

@erri120 erri120 merged commit a00526f into Nexus-Mods:main Mar 12, 2024
@erri120 erri120 deleted the fix/style-config-file branch March 12, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Tech-debt Technical debt, this needs solving in the long-term
3 participants