Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes and refinements #1015

Merged
merged 23 commits into from
Mar 4, 2024
Merged

Apply fixes and refinements #1015

merged 23 commits into from
Mar 4, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 29, 2024

Recap:

  • Apply button now correctly shows up when current loadout revision != last applied revision
  • Apply button now shows Activate text when you need to switch loadouts
  • Apply button now ingests outside changes and merges uncommitted changes on top
  • Launch button no longer applies, but still merges at the end of the run
  • Last applied revision is now correctly saved and restored
  • Bunch of Apply button styling fixes and improvements

Warning!

This requires nuking the Datamodel. App will crash and burn otherwise as its missing lastAppliedRevision

@Al12rs Al12rs requested a review from a team February 29, 2024 15:58
@Al12rs Al12rs self-assigned this Feb 29, 2024
@Al12rs Al12rs requested a review from erri120 March 4, 2024 12:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 31.40496% with 166 lines in your changes are missing coverage. Please review.

Project coverage is 56.99%. Comparing base (9f8e770) to head (d9d8214).
Report is 21 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
- Coverage   58.19%   56.99%   -1.21%     
==========================================
  Files         644      644              
  Lines       21069    21200     +131     
  Branches     1650     1653       +3     
==========================================
- Hits        12261    12082     -179     
- Misses       8411     8721     +310     
  Partials      397      397              
Flag Coverage Δ
Linux 56.20% <31.40%> (-1.29%) ⬇️
Windows 56.14% <31.40%> (-1.26%) ⬇️
clean_environment_tests 56.97% <31.40%> (-1.21%) ⬇️
macOS 55.65% <31.40%> (-1.24%) ⬇️
network_tests ?
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/NexusMods.Abstractions.Serialization/Services.cs 100.00% <100.00%> (ø)
src/NexusMods.DataModel/ToolManager.cs 90.00% <100.00%> (+20.00%) ⬆️
....StandardGameLocators.TestHelpers/ListFilesTool.cs 100.00% <100.00%> (ø)
...p.UI/LeftMenu/Items/ApplyControlDesignViewModel.cs 0.00% <0.00%> (ø)
.../NexusMods.DataModel/Loadouts/DiskStateRegistry.cs 93.18% <90.47%> (-3.25%) ⬇️
tests/NexusMods.DataModel.Tests/ToolTests.cs 0.00% <0.00%> (ø)
.../NexusMods.Abstractions.DiskState/DiskStateTree.cs 76.31% <55.55%> (-8.00%) ⬇️
...rc/NexusMods.App.UI/Resources/Language.Designer.cs 57.63% <0.00%> (-2.51%) ⬇️
src/NexusMods.DataModel/ApplyService.cs 66.23% <62.71%> (+66.23%) ⬆️
...ods.App.UI/LeftMenu/Items/ApplyControlViewModel.cs 0.00% <0.00%> (ø)
... and 1 more

... and 24 files with indirect coverage changes

@Al12rs Al12rs requested a review from erri120 March 4, 2024 12:31
@Al12rs Al12rs merged commit 4336166 into main Mar 4, 2024
6 checks passed
@Al12rs Al12rs deleted the Apply_fixes branch March 4, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants