-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply fixes and refinements #1015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the game without applying or ingesting.
…n top of outside changes.
…side changes after run
halgari
approved these changes
Mar 1, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
…t matching the loadoutID is not found
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
- Coverage 58.19% 56.99% -1.21%
==========================================
Files 644 644
Lines 21069 21200 +131
Branches 1650 1653 +3
==========================================
- Hits 12261 12082 -179
- Misses 8411 8721 +310
Partials 397 397
Flags with carried forward coverage won't be shown. Click here to find out more.
|
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
reviewed
Mar 4, 2024
erri120
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GameInstallation
in the DataStore #986DiskState
is stored with loadout revision id that is not guaranteed to match the state #984Recap:
Warning!
This requires nuking the Datamodel. App will crash and burn otherwise as its missing lastAppliedRevision