Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Stardew Valley diagnostics #1007

Merged
merged 15 commits into from
Feb 28, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Feb 28, 2024

Using the new diagnostic system, this PR updates/adds the following diagnostics:

  • Mod {Mod} is missing required dependency {MissingDependency}
  • Mod {Dependent} requires at least version {MinimumVersion} of {Dependency} but installed is {CurrentVersion}

Both of these diagnostics work for mod and content pack dependencies.

Resolves #915.

@erri120 erri120 added this to the v0.4 milestone Feb 28, 2024
@erri120 erri120 requested a review from a team February 28, 2024 10:17
@erri120 erri120 self-assigned this Feb 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 3.42857% with 169 lines in your changes are missing coverage. Please review.

Project coverage is 57.02%. Comparing base (9f8e770) to head (15f1603).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   58.19%   57.02%   -1.18%     
==========================================
  Files         644      643       -1     
  Lines       21069    21024      -45     
  Branches     1650     1638      -12     
==========================================
- Hits        12261    11988     -273     
- Misses       8411     8654     +243     
+ Partials      397      382      -15     
Flag Coverage Δ
Linux 56.24% <3.42%> (-1.26%) ⬇️
Windows 56.23% <3.42%> (-1.18%) ⬇️
clean_environment_tests 57.00% <3.42%> (-1.18%) ⬇️
macOS 55.70% <3.42%> (-1.20%) ⬇️
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/Games/NexusMods.Games.StardewValley/Constants.cs 0.00% <ø> (-100.00%) ⬇️
...rc/Games/NexusMods.Games.StardewValley/Services.cs 100.00% <100.00%> (ø)
.../Games/NexusMods.Games.StardewValley/TypeFinder.cs 100.00% <100.00%> (ø)
...cs/DiagnosticTemplateIncrementalSourceGenerator.cs 81.14% <100.00%> (-1.02%) ⬇️
...mes/NexusMods.Games.StardewValley/StardewValley.cs 22.22% <0.00%> (-46.67%) ⬇️
...ractions.Loadouts/Extensions/AModFileExtensions.cs 0.00% <0.00%> (ø)
src/Games/NexusMods.Games.StardewValley/Interop.cs 0.00% <0.00%> (ø)
...Games/NexusMods.Games.StardewValley/Diagnostics.cs 0.00% <0.00%> (-100.00%) ⬇️
...ames.StardewValley/Installers/SMAPIModInstaller.cs 0.00% <0.00%> (-92.50%) ⬇️
...rdewValley/Emitters/DependencyDiagnosticEmitter.cs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@erri120 erri120 merged commit 3d936f1 into Nexus-Mods:main Feb 28, 2024
7 checks passed
@erri120 erri120 deleted the feat/915-stardew-valley-diagnostics branch February 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants