Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Style aliases for Spacing and CornerRadius #1001

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 27, 2024

  • Use an alias system for Spacing and CornerRadius which will allow easy Theme updates in the future.
  • Added Style classes for StackPanel spacing and Border corner radius.
  • Updated StyleGuidelines with the new Palettes and UnifiedIcon
  • Updated Focus color name
@Al12rs Al12rs requested a review from a team February 27, 2024 09:41
@Al12rs Al12rs self-assigned this Feb 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.11%. Comparing base (174188e) to head (2a318ae).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1001   +/-   ##
=======================================
  Coverage   58.10%   58.11%           
=======================================
  Files         644      644           
  Lines       21056    21056           
  Branches     1642     1641    -1     
=======================================
+ Hits        12235    12236    +1     
+ Misses       8432     8428    -4     
- Partials      389      392    +3     
Flag Coverage Δ
Linux 57.41% <100.00%> (-0.04%) ⬇️
Windows 57.38% <100.00%> (+0.03%) ⬆️
clean_environment_tests 58.09% <100.00%> (+<0.01%) ⬆️
macOS 56.80% <100.00%> (ø)
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...exusFluentDark/Styles/Controls/Border/Toolbar.xaml 97.50% <100.00%> (ø)
...sFluentDark/Styles/Controls/Button/PillStyles.xaml 98.91% <100.00%> (ø)

... and 7 files with indirect coverage changes

@Al12rs Al12rs requested a review from erri120 February 27, 2024 09:51
@Al12rs Al12rs merged commit c167274 into main Feb 27, 2024
8 checks passed
@Al12rs Al12rs deleted the sizes_and_corner_radius branch February 27, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants