Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color system updates #1000

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Color system updates #1000

merged 4 commits into from
Feb 26, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 26, 2024

fix #978

  • Use new shorter and simplified names
  • Use "Surface" instead of "Background"
  • Updated StrokeTranslucent values
  • Shift Warning color usages noop as there were no usages to update
  • Added folder for ControlThemes and moved UnifiedIconControlTheme to it
@Al12rs Al12rs requested a review from a team February 26, 2024 13:20
@Al12rs Al12rs self-assigned this Feb 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.12%. Comparing base (e0f85cb) to head (c704b7c).
Report is 17 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   58.13%   58.12%   -0.01%     
==========================================
  Files         644      644              
  Lines       21056    21056              
  Branches     1642     1641       -1     
==========================================
- Hits        12240    12238       -2     
  Misses       8425     8425              
- Partials      391      393       +2     
Flag Coverage Δ
Linux 57.43% <98.03%> (-0.02%) ⬇️
Windows 57.35% <98.03%> (+0.02%) ⬆️
clean_environment_tests 58.10% <98.03%> (-0.01%) ⬇️
macOS 56.79% <98.03%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...exusFluentDark/Styles/Controls/Border/Toolbar.xaml 97.50% <100.00%> (ø)
...sFluentDark/Styles/Controls/Button/PillStyles.xaml 98.91% <100.00%> (ø)
...s.App.UI/Controls/GameWidget/GameWidgetStyles.xaml 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@Al12rs Al12rs merged commit 174188e into main Feb 26, 2024
7 checks passed
@erri120 erri120 deleted the color_system_updates branch February 26, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants