Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for Review] Improve native resume #1884

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Conversation

darinyu
Copy link
Collaborator

@darinyu darinyu commented Jun 11, 2024

Extend the resume speedup change to native(local) resume.

Note:

  • We will go over all the successful tasks and copy them first. Then we reconstruct runtime queue to continue.
  • We will keep UBF resume behavior the same. i.e if some mapper tasks fail, all mapper tasks will reran in the resume.

A few test example flows:

  • Resume w/ some branch: link
  • Resume during failure on foreach split :link
  • Resume during failure on UBF split: link
  • Resume during failure on UBF join: link

To test the above flows:

python flow.py run
python flow.py resume

Benchmark:
Resume-Speed-Test-Google-Docs

Open question:

  • We only consider last "run" but never consider last "resume", so running multiple resume will anchor on the same run_id (instead of previous resume). If running resume consecutively, should we continue on the resume?
@darinyu darinyu changed the title [WIP] Improve native resume Jun 11, 2024
@savingoyal savingoyal self-requested a review June 18, 2024 14:58
@savingoyal
Copy link
Collaborator

@darinyu can you walk me through the nature of changes for this PR so that we can have a quick review turnaround?

@savingoyal
Copy link
Collaborator

not related to this PR but maybe we can mute this log line

@darinyu darinyu force-pushed the improve_native_resume branch 2 times, most recently from 417f537 to a172154 Compare June 27, 2024 16:21
@darinyu darinyu changed the title [Open for feedback] Improve native resume Jun 27, 2024
@saikonen saikonen self-requested a review July 1, 2024 16:49
@savingoyal
Copy link
Collaborator

ready to go

@darinyu darinyu merged commit 020d1c2 into master Jul 19, 2024
26 checks passed
@darinyu darinyu deleted the improve_native_resume branch July 19, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants