feat: support additional components inside forms #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/additional-components-in-forms
branch
from
99bbf6d
to
f43bc38
Compare
|
@metamaskbot update-pr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2497 +/- ##
=======================================
Coverage 94.35% 94.36%
=======================================
Files 441 441
Lines 9076 9068 -8
Branches 1398 1396 -2
=======================================
- Hits 8564 8557 -7
+ Misses 512 511 -1 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/additional-components-in-forms
branch
from
7da07b6
to
6d4c157
Compare
Mrtenz
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for additional components inside forms, essentially allowing all children of
Boxto also be children ofForm. AlthoughFormremains the only component whereFieldcan exist. This also means forms can now be nested, when this happens the input state is tied to the nearest parent form.To support this change, a refactor of the
constructStatefunction was done. This function now useswalkJsxto walk the entire JSX tree and collect state values.Closes #2496