Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tooltip component #2490

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Add Tooltip component #2490

merged 4 commits into from
Jun 18, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Jun 14, 2024 •
edited
Loading

This adds a new component Tooltip which can be used to display a tooltip on a text element or an image.

<Tooltip content="foo">
  <Text>bar</Text>
</Tooltip>

This component can wrap any text element (Text, Italic, Bold, Link) and Image and accepts a string or a text element (Text, Italic, Bold, Link) to be displayed inside it via its value prop.
@GuillaumeRx GuillaumeRx requested a review from a team as a code owner June 14, 2024 10:50
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (b68a7c0) to head (931dbad).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2490   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files         440      441    +1     
  Lines        9070     9076    +6     
  Branches     1398     1398           
=======================================
+ Hits         8558     8564    +6     
  Misses        512      512

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
FrederikBolding
FrederikBolding previously approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please address @Mrtenz comments as well!
Mrtenz
Mrtenz requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments above.
@GuillaumeRx GuillaumeRx requested a review from Mrtenz June 18, 2024 10:46
@GuillaumeRx GuillaumeRx merged commit 43205de into main Jun 18, 2024
156 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/tooltip-component branch June 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@GuillaumeRx @FrederikBolding @Mrtenz