BREAKING: Defer creation of offscreen document in OffscreenExecutionService
#2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/snaps-controllers/src/services/offscreen/OffscreenExecutionService.ts
Show resolved
Hide resolved
Mrtenz
force-pushed
the
mrtenz/remove-offscreen-executor-create-document
branch
from
576882c
to
8661b54
Compare
FrederikBolding
previously approved these changes
Jun 13, 2024
|
@Mrtenz Can you update the PR title and description for the new content? Also should probably be marked as breaking |
FrederikBolding
approved these changes
Jun 13, 2024
Mrtenz
changed the title
OffscreenExecutionService
Mrtenz
force-pushed
the
mrtenz/remove-offscreen-executor-create-document
branch
from
d583e96
to
807deb6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2473 +/- ##
==========================================
- Coverage 94.34% 94.34% -0.01%
==========================================
Files 439 439
Lines 9057 9054 -3
Branches 1392 1391 -1
==========================================
- Hits 8545 8542 -3
Misses 512 512 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the offscreen document needed to be created from the
OffscreenExecutionServicebecause the extension did not do any offscreen set up. Nowadays though, the offscreen document is used by the extension for functionality other than Snaps, and the set up is handled from the extension.Instead, we the offscreen service now accepts a
Promisewhich should resolve when the offscreen document is ready. The service will wait for the promise to resolve before continuing.