Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add value component #2435

Merged
merged 7 commits into from
May 28, 2024
Merged

feat: Add value component #2435

merged 7 commits into from
May 28, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented May 27, 2024

Adds the Value component, which can be used to show two text values side-by-side where one is highlighted. This component is only allowed as a child of Row.

Progresses https://github.com/MetaMask/MetaMask-planning/issues/1686

@FrederikBolding FrederikBolding requested a review from a team as a code owner May 27, 2024 10:39
@FrederikBolding FrederikBolding changed the title feat: Add double value component May 27, 2024
@FrederikBolding
Copy link
Member Author

@metamaskbot update-pr

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (10a9f79) to head (90b2458).
Report is 1 commits behind head on main.

Current head 90b2458 differs from pull request most recent head caae1f0

Please upload reports for the commit caae1f0 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2435   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files         437      438    +1     
  Lines        8987     8991    +4     
  Branches     1378     1378           
=======================================
+ Hits         8475     8479    +4     
  Misses        512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 6bd631e into main May 28, 2024
151 checks passed
@FrederikBolding FrederikBolding deleted the fb/double-value-component branch May 28, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants