feat: add feature flag to disable platform #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/add-feature-flag-to-disable-platform
branch
from
e2a497e
to
173cc7a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
=======================================
Coverage 94.30% 94.30%
=======================================
Files 437 437
Lines 8987 8997 +10
Branches 1378 1379 +1
=======================================
+ Hits 8475 8485 +10
Misses 512 512 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
May 28, 2024
FrederikBolding
force-pushed
the
fb/add-feature-flag-to-disable-platform
branch
from
8f04599
to
04ad368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
getFeatureFlagsconstructor argument that can return dynamic feature flags at runtime, use the feature flag to assert whether the Snaps platform is allowed to run.Closes https://github.com/MetaMask/MetaMask-planning/issues/2556