fix: properly handle invalid interfaces during test #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
commented
May 24, 2024
FrederikBolding
force-pushed
the
fb/fix-test-timeout-with-invalid-jsx
branch
from
2a06327
to
fffea18
Compare
FrederikBolding
changed the title
Mrtenz
reviewed
May 28, 2024
| @@ -60,6 +72,12 @@ export function handleRequest({ | |||
| runSaga, | |||
| request: { id = nanoid(), origin = 'https://metamask.io', ...options }, | |||
| }: HandleRequestOptions): SnapRequest { | |||
| const getInterfaceError = () => { | |||
| throw new Error( | |||
| 'Unable to get the interface from the Snap: The returned interface may be invalid.', | |||
There was a problem hiding this comment.
Not sure if this error makes sense if the entire request failed?
There was a problem hiding this comment.
Unable to get the interface from the Snap: The request to the Snap failed. ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2433 +/- ##
=======================================
Coverage 94.31% 94.32%
=======================================
Files 438 438
Lines 9001 9016 +15
Branches 1379 1382 +3
=======================================
+ Hits 8489 8504 +15
Misses 512 512 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
.getInterface()with a Snap that produces an invalid interface, the tests would previously time out. This PR aims to catch the problem and fail sooner with a better error message.