Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly diff when using legacy UI with toRender matcher #2432

Merged
merged 1 commit into from
May 27, 2024

Conversation

FrederikBolding
Copy link
Member

This fixes two problems with diff outputs when using toRender with legacy UI:

  • Firstly we had flipped actual and expected causing confusing output
  • Secondly we were diffing not just the content but also the rest of the response object unnecessarily
@FrederikBolding FrederikBolding requested a review from a team as a code owner May 24, 2024 07:50
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (5e6db9d) to head (3ecb733).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2432   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files         437      437           
  Lines        8987     8987           
  Branches     1378     1378           
=======================================
  Hits         8475     8475           
  Misses        512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 00a9587 into main May 27, 2024
153 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-toRenderLegacy-diff branch May 27, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants