Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ed25519Bip32 to the BIP-32 example snap #2428

Merged
merged 6 commits into from
May 27, 2024

Conversation

bowensanders
Copy link
Contributor

@bowensanders bowensanders commented May 22, 2024

Add support for the ed25519Bip32 curve to the BIP-32 example Snap for E2E testing purposes.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (00a9587) to head (769fc82).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2428   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files         437      437           
  Lines        8987     8987           
  Branches     1378     1378           
=======================================
  Hits         8475     8475           
  Misses        512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding marked this pull request as ready for review May 27, 2024 09:13
@FrederikBolding FrederikBolding requested a review from a team as a code owner May 27, 2024 09:13
@FrederikBolding FrederikBolding changed the title Add support for ed25519/cip-3 to the bip-32 example snap May 27, 2024
@FrederikBolding FrederikBolding merged commit 1d0be14 into main May 27, 2024
152 checks passed
@FrederikBolding FrederikBolding deleted the bowen/bip32-cip3-exsnap branch May 27, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants