chore: Revamp interactive UI example using JSX #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
previously approved these changes
May 22, 2024
FrederikBolding
force-pushed
the
fb/revamp-interactive-ui-example
branch
from
3fd011b
to
da163b4
Compare
FrederikBolding
commented
May 23, 2024
| @@ -81,4 +83,5 @@ export type UserInputEvent = Infer<typeof UserInputEventStruct>; | |||
| export type OnUserInputHandler = (args: { | |||
| id: string; | |||
| event: UserInputEvent; | |||
| context: InterfaceContext | null; | |||
There was a problem hiding this comment.
Forgot to add this type in #2413
FrederikBolding
force-pushed
the
fb/revamp-interactive-ui-example
branch
from
23fc1db
to
03ae2e4
Compare
GuillaumeRx
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamps the interactive UI example, rewriting most of the UI logic in JSX and removing the
getStatefunctionality.This will let us more easily test different types of inputs once added as well, e.g.
Dropdown.This also uses the new
contextproperty and lets us remove the usage ofmanageStateentirely from the Snap.