Add connections diff calculations needed for Snap update #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david0xd
force-pushed
the
dd/connection-difference
branch
from
7b512bf
to
1e3a008
Compare
Adjust coverage Adjust coverage again Refactor code and add new tests
david0xd
force-pushed
the
dd/connection-difference
branch
from
05299da
to
3b22e41
Compare
FrederikBolding
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional logic for calculating difference of
initialConnections. This is required so changes can be displayed in the UI for Snap update process.New method is added to
SnapControllerand integrated within Snap update handling functions.