fix: correct validation for children of Box component #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
commented
May 22, 2024
| * This set should include all components, except components that need to be nested | ||
| * in another component (e.g. Field must be contained in a Form). | ||
| */ | ||
| export const BoxChildStruct = nullUnion([ |
There was a problem hiding this comment.
This is all of the structs included in JSXElementStruct, excluding FieldStruct
|
@metamaskbot update-pr |
GuillaumeRx
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem where
Fieldwas allowed as a child ofBoxor as the content of a UI by itself. The implementation assumes elsewhere thatFieldis always a child ofFormand so the validation should uphold that.Note: We should revisit the decision to require
Fieldalways being a child of aFormlater since it would make sense to allowBoxwithin forms as well for positioning. But this requires a validation refactor.