refactor!(snaps-rpc-methods): Use hooks in wallet_invokeSnap instead of remapping the request to wallet_snap
#2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of remapping the request to wallet_snap
packages/snaps-rpc-methods/src/permitted/invokeSnapSugar.test.ts
Outdated
Show resolved
Hide resolved
…nstead of remapping the request to wallet_snap
FrederikBolding
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #2398
We are moving our permission middleware ahead of all RPC method implementations in the extension (MetaMask/metamask-extension#24472) and mobile (MetaMask/metamask-mobile#9521). This breaks the current implementation of
wallet_invokeSnap, which assumes that it's called before the permission middleware (which calls the implementation ofwallet_snap, which is a restricted method).This PR refactors
wallet_invokeSnapto use aninvokeSnap()hook, intended to bePermissionController.executeRestrictedMethod()bound to the requesting origin and'wallet_snap'.