fix(cors): ACAO header was not sent when conf.origins has multiple
#13334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entries and has `*` included
The CORS plugin allows the use of the wildcard "*" to match all origins.
However, when multiple entries are configured in `conf.origins` and one
of them is "*", the CORS plugin fails to send the ACAO response header.
Additionally, the logs report an error entry like `pcre2_compile()
failed: quantifier does not follow a repeatable item in "*$" at
"*$"`.
This fix addresses the issue, and ensures consistent behavior with
when setting "*" as a single value in `conf.origins`.
github-actions
bot
added
plugins/cors
cherry-pick kong-ee
outsinre
approved these changes
Jul 12, 2024
catbro666
approved these changes
Jul 23, 2024
tzssangglass
approved these changes
Jul 24, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The CORS plugin allows the use of the wildcard
*to match all origins. However, when multiple entries are configured inconf.originsand one of them is*, the CORS plugin fails to send the ACAO response header. Additionally, the logs report an error entry likepcre2_compile() failed: quantifier does not follow a repeatable item in "*$" at "*$".This fix addresses the issue, and ensures consistent behavior with when setting
*as a single value inconf.origins.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-6062