Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix lua-nginx-module context was cleared when ngx.send_header() trigger filter_finalize case #13316

Merged
merged 11 commits into from
Jul 15, 2024

Conversation

oowl
Copy link
Member

@oowl oowl commented Jul 1, 2024

Summary

backport patch in openresty/lua-nginx-module#2323

Context: openresty/lua-nginx-module#2320

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-6005

@github-actions github-actions bot added build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 1, 2024
@chronolaw chronolaw changed the title fix(core): fix lua-nginx-module context was clear when ngx.send_heade… Jul 1, 2024
@oowl oowl force-pushed the fix/filter_finalize_in_send_header branch from 5b7a4b8 to 79e3dd8 Compare July 2, 2024 09:38
@kikito kikito force-pushed the fix/filter_finalize_in_send_header branch from b135a36 to 0eaebd1 Compare July 9, 2024 08:25
@oowl
Copy link
Member Author

oowl commented Jul 9, 2024

hold on, I need to fix a test case conflict issue, So please do not do any rebase until I fix all the CI.

@chronolaw chronolaw self-requested a review July 9, 2024 08:52
@oowl oowl force-pushed the fix/filter_finalize_in_send_header branch from 0eaebd1 to 1cd4be2 Compare July 12, 2024 06:49
@oowl oowl force-pushed the fix/filter_finalize_in_send_header branch 4 times, most recently from 3cceca5 to 7c19e16 Compare July 14, 2024 08:15
@oowl oowl force-pushed the fix/filter_finalize_in_send_header branch from 7c19e16 to 0c69a83 Compare July 14, 2024 08:15
@windmgc windmgc merged commit fb63631 into master Jul 15, 2024
26 checks passed
@windmgc windmgc deleted the fix/filter_finalize_in_send_header branch July 15, 2024 06:26
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/M
5 participants