[backport -> release/3.7.x] fix(redis): remove unnecessary redis config deprecation warnings in hybrid mode #13305
+234
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running kong in hybrid mode a plugin configuration is pushed from CP to DP. When introducing shorthand field expansion to Admin responses the deprecated fields (defined as shorthand fields) were also pushed from CP to DP which resulted in DP receiving config with both new fields and also old fields. It resulted with DP reporting in logs that the plugin is being configured with deprecated fields. It affected the plugins: - ACME - Rate-Limiting - Response-RateLimiting This commit disables deprecation warning on data planes since those nodes cannot be configured manually so this deprecation message is not actionable on data planes. KAG-4515 (cherry picked from commit a806308)
team-gateway-bot
added
cherry-pick kong-ee
3 tasks
nowNick
approved these changes
Jun 26, 2024
|
I'm converting this to draft until I get a confirmation that we plan to backport this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release/3.7.x, triggered by a label in #13069.Original description
Summary
When running kong in hybrid mode with ACME plugin the configuration for the plugin is being pushed from CP to DP. When introducing shorthand field expansion to Admin API responses the deprecated fields (defined as shorthand fields) were also pushed from CP to DP which resulted in DP receiving config with both new fields and also old fields. It resulted with DP reporting in logs that ACME plugin is being configured with deprecated fields.
This PR disables the deprecation logs in DPs. The reasoning behind that is that those deprecation logs are not actionable on DP side and should be actually changed on CP if they were indeed configured improperly.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4515