Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced transformation integration for forward migration #855

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

shreyakhajanchi
Copy link
Collaborator

@shreyakhajanchi shreyakhajanchi commented Jul 4, 2024

Tests run:

  1. Minimal downtime migration via sharded flow
  2. Minimal downtime migration via non-sharded flow

UI:

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.95%. Comparing base (e49e4f1) to head (91f323d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
+ Coverage   45.43%   45.95%   +0.52%     
==========================================
  Files         166      166              
  Lines       21639    21656      +17     
  Branches      515      515              
==========================================
+ Hits         9832     9953     +121     
+ Misses      11246    11140     -106     
- Partials      561      563       +2     
Components Coverage Δ
backend-apis 45.14% <100.00%> (+1.05%) ⬆️
backend-library 52.14% <27.27%> (+0.33%) ⬆️
cli 5.14% <ø> (ø)
frontend 33.90% <100.00%> (+0.50%) ⬆️
Files Coverage Δ
profiles/source_profile.go 87.03% <ø> (ø)
ui/src/app/app.constants.ts 100.00% <ø> (ø)
...omponents/dataflow-form/dataflow-form.component.ts 100.00% <100.00%> (+70.83%) ⬆️
...s/prepare-migration/prepare-migration.component.ts 16.78% <ø> (ø)
webv2/web.go 6.88% <100.00%> (+6.19%) ⬆️
streaming/streaming.go 16.95% <27.27%> (+6.64%) ⬆️
@shreyakhajanchi shreyakhajanchi marked this pull request as ready for review July 5, 2024 03:37
@shreyakhajanchi shreyakhajanchi requested a review from a team as a code owner July 5, 2024 03:37
@shreyakhajanchi shreyakhajanchi requested review from Deep1998 and VardhanThigle and removed request for a team July 5, 2024 03:37
@shreyakhajanchi shreyakhajanchi marked this pull request as draft July 5, 2024 03:38
streaming/streaming.go Show resolved Hide resolved
@shreyakhajanchi shreyakhajanchi marked this pull request as ready for review July 6, 2024 16:17
@shreyakhajanchi shreyakhajanchi removed the request for review from Deep1998 July 6, 2024 16:25
@shreyakhajanchi shreyakhajanchi merged commit 8ac83cb into master Jul 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants