Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL foreign key action handling at the backend with warning generation #854

Merged
merged 11 commits into from
Jul 5, 2024
Merged

MySQL foreign key action handling at the backend with warning generation #854

merged 11 commits into from
Jul 5, 2024

Conversation

aasthabharill
Copy link
Contributor

@aasthabharill aasthabharill commented Jul 3, 2024 •
edited
Loading

Tasks Handled in this PR:

  1. Backend changes to incorporate foreign key actions in MySQL end to end including:
    a. Inferring source actions
    b. Conversion of action from source schema to spanner schema
    c. DDL generation
  2. Warning generation in Report

Unit tests for existing functions were extended and new unit tests were added for new functions.

  • Tests pass
  • Appropriate changes to README are included in PR
@aasthabharill aasthabharill requested a review from a team as a code owner July 3, 2024 12:15
@aasthabharill aasthabharill requested review from Deep1998 and aksharauke and removed request for a team July 3, 2024 12:15
Deep1998
Deep1998 reviewed Jul 4, 2024
View reviewed changes
internal/mapping.go Outdated Show resolved Hide resolved
Deep1998
Deep1998 reviewed Jul 4, 2024
View reviewed changes
internal/mapping.go Outdated Show resolved Hide resolved
Deep1998
Deep1998 reviewed Jul 4, 2024
View reviewed changes
webv2/api/schema.go Outdated Show resolved Hide resolved
Deep1998
Deep1998 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@Deep1998 Deep1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, very well written code with great test coverage across MySQL dump and PG dialect as well.

I also see some new tests added for methods that you only modified. Thanks for going above and beyond.

LGTM with minor comments.
manitgupta
manitgupta reviewed Jul 4, 2024
View reviewed changes
internal/mapping.go Outdated Show resolved Hide resolved
internal/mapping.go Outdated Show resolved Hide resolved
shreyakhajanchi
shreyakhajanchi approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work on adding good test coverage and quality code with comments.
@shreyakhajanchi shreyakhajanchi merged commit 3f48409 into GoogleCloudPlatform:master Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL
5 participants
@aasthabharill @manitgupta @Deep1998 @shreyakhajanchi @aasthabharill-google