Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to configure metadata gcs bucket #835

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

asthamohta
Copy link
Collaborator

No description provided.

@asthamohta asthamohta requested a review from a team as a code owner June 12, 2024 16:46
@asthamohta asthamohta requested review from manitgupta and shreyakhajanchi and removed request for a team June 12, 2024 16:46
Copy link
Collaborator

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Left minor comments

webv2/web.go Outdated Show resolved Hide resolved
webv2/web.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the mentioned changes before merging

@asthamohta asthamohta merged commit a094afc into GoogleCloudPlatform:master Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants