Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators in SMT #834

Merged

Conversation

NirnayaSindhuSuthari
Copy link
Contributor

@NirnayaSindhuSuthari NirnayaSindhuSuthari commented Jun 9, 2024

Fixes b/295990119

-Added Validators on SMT Database name and Index name.
-Added regex, icon, message and link of naming convention in Database form.
-Added regex, message and link of naming convention in Index form.
-Modified count Checker

-Adding screenshots
Screenshot from 2024-06-10 05-37-10
Screenshot from 2024-06-10 05-38-22

@NirnayaSindhuSuthari NirnayaSindhuSuthari requested a review from a team as a code owner June 9, 2024 11:11
@NirnayaSindhuSuthari NirnayaSindhuSuthari requested review from darshan-sj and krishnamoorthy-r and removed request for a team June 9, 2024 11:11
Copy link
Contributor Author

@NirnayaSindhuSuthari NirnayaSindhuSuthari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with changes required.

Copy link
Collaborator

@asthamohta asthamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Congratulations on your first merge

@asthamohta asthamohta merged commit cefd0a3 into GoogleCloudPlatform:master Jun 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants