Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for converting auto-increment to sequence #832

Merged
merged 63 commits into from
Jun 24, 2024
Merged

feat: Add support for converting auto-increment to sequence #832

merged 63 commits into from
Jun 24, 2024

Conversation

asthamohta
Copy link
Collaborator

@asthamohta asthamohta commented Jun 3, 2024 •
edited
Loading

image

UI Changes:

  • A new type of issue is added
  • Src Schema shows Auto-Generated Column

Changes:

  • Auto-Increment in MySql is mapped to a new sequence which is created
@asthamohta asthamohta requested a review from a team as a code owner June 3, 2024 17:05
@asthamohta asthamohta requested review from manitgupta and krishnamoorthy-r and removed request for a team June 3, 2024 17:05
manitgupta
manitgupta requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@manitgupta manitgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of interfaces are polluted it seems to be by adding driver. Can you add the reason why source database type is relevant to functions like ReadSpannerSchema, ValidateExistingDb etc.?
cmd/data.go Outdated Show resolved Hide resolved
@asthamohta asthamohta merged commit 74e76a4 into GoogleCloudPlatform:master Jun 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L
2 participants
@asthamohta @manitgupta