Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create sequence UI #828

Merged
merged 46 commits into from
Jun 3, 2024
Merged

feat: create sequence UI #828

merged 46 commits into from
Jun 3, 2024

Conversation

asthamohta
Copy link
Collaborator

@asthamohta asthamohta commented May 29, 2024 •
edited
Loading

UI Screenshots
Screenshot 2024-05-30 at 3 47 26 AM
Screenshot 2024-05-30 at 3 47 42 AM
Screenshot 2024-05-30 at 3 47 53 AM
Screenshot 2024-05-30 at 3 50 24 AM
Screenshot 2024-05-30 at 3 48 08 AM
Screenshot 2024-05-30 at 3 48 15 AM
Screenshot 2024-05-30 at 3 48 24 AM
@asthamohta asthamohta requested a review from a team as a code owner May 29, 2024 21:11
@asthamohta asthamohta requested review from bharadwaj-aditya and aksharauke and removed request for a team May 29, 2024 21:11
aksharauke
aksharauke reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@aksharauke aksharauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume document update will be in a different PR.
I also suggest to get a review from someone more experienced in Angular since my knowledge there is limited.
ui/src/app/components/object-explorer/object-explorer.component.ts Outdated Show resolved Hide resolved
ui/src/app/model/auto-gen.ts Show resolved Hide resolved
bharadwaj-aditya
bharadwaj-aditya reviewed May 30, 2024
View reviewed changes
ui/cypress/e2e/spec.cy.ts Outdated Show resolved Hide resolved
ui/src/app/app.constants.ts Show resolved Hide resolved
ui/src/app/components/add-new-sequence/add-new-sequence.component.html Show resolved Hide resolved
ui/src/app/components/add-new-sequence/add-new-sequence.component.html Show resolved Hide resolved
ui/src/app/components/object-detail/object-detail.component.html Show resolved Hide resolved
ui/src/app/components/object-detail/object-detail.component.scss Outdated Show resolved Hide resolved
ui/src/app/components/object-detail/object-detail.component.ts Outdated Show resolved Hide resolved
ui/src/app/components/object-detail/object-detail.component.ts Outdated Show resolved Hide resolved
ui/src/app/model/edit-table.ts Show resolved Hide resolved
ui/src/app/services/conversion/conversion.service.ts Outdated Show resolved Hide resolved
@bharadwaj-aditya
Copy link
Collaborator

Looks much better now. PTAL at the common CSS bit
shreyakhajanchi
shreyakhajanchi reviewed Jun 3, 2024
View reviewed changes
ui/src/app/app.constants.ts Outdated Show resolved Hide resolved
ui/src/mocks/conv.ts Outdated Show resolved Hide resolved
ui/src/app/services/fetch/fetch.service.ts Outdated Show resolved Hide resolved
ui/src/app/model/auto-gen.ts Show resolved Hide resolved
ui/src/app/services/conversion/conversion.service.ts Show resolved Hide resolved
ui/src/app/components/object-detail/object-detail.component.ts Show resolved Hide resolved
shreyakhajanchi
shreyakhajanchi approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. left few minor comments
ui/src/app/services/conversion/conversion.service.ts Show resolved Hide resolved
@asthamohta asthamohta merged commit 8c5e085 into GoogleCloudPlatform:master Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL
4 participants
@asthamohta @bharadwaj-aditya @shreyakhajanchi @aksharauke