Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpu] do not require signing metadata #1193

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

cjac
Copy link
Contributor

@cjac cjac commented Jun 28, 2024

  • wrapped signing code in conditional that checks for private key
  • replaced tabs with spaces
  • made use of get_metadata_attribute more frequently
  • using default value of "" unless otherwise supplied
  • using CUDA subversion of 12.4.1
  • building source in /opt/install-nvidia-driver
* wrapped signing code in conditional that checks for private key
* replaced tabs with spaces
* made use of get_metadata_attribute more frequently
* using default value of "" unless otherwise supplied
* using CUDA subversion of 12.4.1
* building source in /opt/install-nvidia-driver
@cjac cjac requested a review from prince-cs June 28, 2024 18:18
@prince-cs
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@prince-cs prince-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prince-cs
Copy link
Collaborator

/gcbrun

@kuldeepkk-dev kuldeepkk-dev self-requested a review June 28, 2024 18:44
Copy link
Contributor

@kuldeepkk-dev kuldeepkk-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjac cjac merged commit 94e3f19 into GoogleCloudDataproc:master Jun 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants