Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bigtable.sh - Debian buster repo issue #1164

Conversation

kuldeepkk-dev
Copy link
Contributor

No description provided.

@kuldeepkk-dev
Copy link
Contributor Author

/gcbrun

Copy link
Collaborator

@prince-cs prince-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cjac cjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the conditional around remove_old_backports could use a tweak...

bigtable/bigtable.sh Outdated Show resolved Hide resolved
Added condition to consider 2.1 Dataproc image version for debian as suggsted by the reviewers
Copy link
Contributor

@cjac cjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjac
Copy link
Contributor

cjac commented Apr 18, 2024

/gcbrun

1 similar comment
@jayadeep-jayaraman
Copy link
Collaborator

jayadeep-jayaraman commented Apr 19, 2024

/gcbrun

@kuldeepkk-dev
Copy link
Contributor Author

/gcbrun

@kuldeepkk-dev
Copy link
Contributor Author

Tests are passing on 2.0 & 2.1. 2.2 failures doesn't seem to be related to this change, merging this.

@kuldeepkk-dev kuldeepkk-dev merged commit 0985c2e into GoogleCloudDataproc:master Apr 19, 2024
1 of 2 checks passed
@kuldeepkk-dev kuldeepkk-dev deleted the bigtable-debian-buster-fix branch April 19, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants