Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backports for releases older than oldstable #1161

Conversation

cjac
Copy link
Contributor

@cjac cjac commented Apr 15, 2024

@cjac
Copy link
Contributor Author

cjac commented Apr 15, 2024

/gcbrun

if [[ -n "$matched_files" ]]; then
for filename in "$matched_files"; do
grep -e "$oldstable-backports" -e "$stable-backports" "$filename" || \
sed -i -e 's/^.*-backports.*$//' "$filename"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this replace the whole line? should we just replace the expression of {non-stable}-backport

Copy link
Contributor

@yigress yigress Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the format on older sources and new sources is different. if there is non-stable, may remove too much with newer format.
dataproc-2.2
cat /etc/apt/sources.list.d/debian.sources
Types: deb deb-src
URIs: mirror+file:///etc/apt/mirrors/debian.list
Suites: bookworm bookworm-updates bookworm-backports
Components: main

Types: deb deb-src
URIs: mirror+file:///etc/apt/mirrors/debian-security.list
Suites: bookworm-security
Components: main

@cjac cjac force-pushed the oldoldstable-backports-removal-gpu branch from 7657e75 to 979f69a Compare April 16, 2024 02:26
Copy link
Collaborator

@jayadeep-jayaraman jayadeep-jayaraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ensure that this function is invoked only for 2.0 and 1.5

@jayadeep-jayaraman jayadeep-jayaraman merged commit 18acb1a into GoogleCloudDataproc:master Apr 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants