Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new init action for Datasketches #1153

Conversation

kuldeepkk-dev
Copy link
Contributor

Added new initialization action for Apache Datasketches.

@kuldeepkk-dev
Copy link
Contributor Author

/gcbrun

@kuldeepkk-dev
Copy link
Contributor Author

/gcbrun

@cjac
Copy link
Contributor

cjac commented Mar 1, 2024

You'll need to add a BUILD file and some tests for the CI framework for gcbrun to trigger. Check with Erick ; he recently added some to an action that was missing them.

datasketches/datasketches.sh Outdated Show resolved Hide resolved
datasketches/datasketches.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@functicons functicons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@functicons
Copy link
Contributor

/gcbrun

@kuldeepkk-dev
Copy link
Contributor Author

Will send another PR for covering test cases, merging this for now to make it available for customers.

@kuldeepkk-dev kuldeepkk-dev merged commit 7da5214 into GoogleCloudDataproc:master Apr 15, 2024
1 of 2 checks passed
@kuldeepkk-dev kuldeepkk-dev deleted the kuldeepkk-datasketches-init-action branch April 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants