Adding Statistics #1128
Merged
Adding Statistics #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
| * @param strBuilder | ||
| */ | ||
| @Subscribe | ||
| private void subscriberOnString(StringBuilder strBuilder) { |
There was a problem hiding this comment.
Let us create a a new type in utils instead of using String type. Strong typing is better.
| @@ -593,8 +593,8 @@ public FSDataOutputStream create( | |||
| .build(), | |||
| statistics), | |||
| statistics); | |||
| globalStorageStatistics.filesCreated(); | |||
| instrumentation.fileCreated(); | |||
There was a problem hiding this comment.
why are we removing this?
There was a problem hiding this comment.
These functions hamper the usage of incrementStatistics() function. I think we should have a single function where we increment both FS based and global counter simultaneously. Also improves code readability
| @@ -726,8 +726,8 @@ public boolean delete(Path hadoopPath, boolean recursive) throws IOException { | |||
| "delete(hadoopPath: %s, recursive: %b): true", hadoopPath, recursive); | |||
| } | |||
| response = result; | |||
| globalStorageStatistics.fileDeleted(1); | |||
| instrumentation.fileDeleted(1); | |||
There was a problem hiding this comment.
why are we removing this?
|
/gcbrun |
| * @param strType | ||
| */ | ||
| @Subscribe | ||
| private void subscriberOnStatisticsType(StatisticsType strType) { |
arunkumarchacko
approved these changes
Mar 18, 2024
| @@ -61,7 +59,7 @@ public class GhfsGlobalStorageStatistics extends StorageStatistics { | |||
| /** {@value} The key that stores all the registered metrics */ | |||
| public static final String NAME = "GhfsStorageStatistics"; | |||
|
|
|||
| public static final int LATENCY_LOGGING_THRESHOLD_MS = 150; | |||
| public static final int LATENCY_LOGGING_THRESHOLD_MS = 300; | |||
There was a problem hiding this comment.
Can you also add the logic to not log this if it is the first request?
guljain
added a commit
to guljain/hadoop-connectors
that referenced
this pull request
Jun 14, 2024
* Adding Statistics * Adding statistics (cherry picked from commit 6698080)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding following statistics:
Also changing LATENCY_LOGGING_THRESHOLD_MS to 300ms