Cleanup for statistics #1125
Merged
Cleanup for statistics #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
|
||
| /** FileSystem-level statistics */ | ||
| DIRECTORIES_CREATED( | ||
| "directories_created", | ||
| "Total number of directories created through the object store.", | ||
| TYPE_COUNTER), | ||
| DIRECTORIES_DELETED( |
There was a problem hiding this comment.
why removing this?
There was a problem hiding this comment.
Directories Deleted isn't used in master, only functions were defined but never actually incremented.
arunkumarchacko
approved these changes
Mar 14, 2024
guljain
added a commit
to guljain/hadoop-connectors
that referenced
this pull request
Jun 14, 2024
* Cleanup for statistics * fixing test * fixing mvn spotless:apply (cherry picked from commit fb30864)
guljain
added a commit
to guljain/hadoop-connectors
that referenced
this pull request
Jun 14, 2024
* Cleanup for statistics * fixing test * fixing mvn spotless:apply (cherry picked from commit fb30864)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up dead code