Add unit tests for GoogleCloudStorageClientImpl. #1095
Conversation
shilpi23pandey
commented
Dec 27, 2023
•
shilpi23pandey
commented
- Adds unit tests for
- listBucket
- deleteBucket
- deleteObjects
- updateObjects
- compose
- copy
- Add redundant APIs for compose and copy so that GoogleCloudStorageClient implementation is invoked for all APIs.
shilpi23pandey
force-pushed
the
unit-tests
branch
2 times, most recently
from
e137d3a
to
fce2276
Compare
|
/gcbrun |
shilpi23pandey
force-pushed
the
unit-tests
branch
from
fce2276
to
bd530a5
Compare
|
/gcbrun |
|
/gcbrun |
| * behavior. | ||
| */ | ||
| @Override | ||
| public void copy( |
There was a problem hiding this comment.
Are we dong more than adding UTs in this PR?
There was a problem hiding this comment.
There are some APIs which share some common code between GoogleCloudStorageImpl and GoogleCloudStorageClientImpl. For example, this copy method implementation is similar for both the clients -they in turn call the https://github.com/GoogleCloudDataproc/hadoop-connectors/pull/1095/files#diff-23a518b24b3819c111aacec5ec168906787ef291585a52e128c1ce776b8ed0fbR246 which contains client specific implementation. To reduce code duplication, this code was not added earlier. However, while writing the UTs realised that with the delegator in place, this method will always call the GoogleCloudStorageImpl copy. So added these implementations here as well.
There was a problem hiding this comment.
Do you want to update the PR description accordingly.
gcsio/src/test/java/com/google/cloud/hadoop/gcsio/integration/GoogleCloudStorageTest.java
Show resolved
Hide resolved
shilpi23pandey
merged commit 5396469
into
GoogleCloudDataproc:master
