-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for GoogleCloudStorageClient createBuckets method. #1093
Add unit tests for GoogleCloudStorageClient createBuckets method. #1093
Conversation
/gcbrun |
/gcbrun |
import java.net.InetSocketAddress; | ||
import java.util.concurrent.TimeUnit; | ||
|
||
public final class FakeServer implements AutoCloseable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, This is part of testing package which wont be visible to tests otherwise.
@@ -0,0 +1,45 @@ | |||
package com.google.cloud.hadoop.gcsio.testing; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add license header. Also for other files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
3d82823
to
8aa5208
Compare
/gcbrun |
No description provided.