Add java-storage implementation for update items method. #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilpi23pandey
force-pushed
the
move-to-java-storage-update-items
branch
from
ae9a5e4
to
565f910
Compare
|
/gcbrun |
shilpi23pandey
force-pushed
the
move-to-java-storage-update-items
branch
from
565f910
to
31595fb
Compare
|
/gcbrun |
shilpi23pandey
force-pushed
the
move-to-java-storage-update-items
branch
from
31595fb
to
22bf404
Compare
|
/gcbrun |
arunkumarchacko
approved these changes
Dec 20, 2023
| Set<IOException> innerExceptions = newConcurrentHashSet(); | ||
| BatchExecutor executor = new BatchExecutor(storageOptions.getBatchThreads()); | ||
|
|
||
| for (UpdatableItemInfo itemInfo : itemInfoList) { |
There was a problem hiding this comment.
let us do this before creating executors etc.
shilpi23pandey
force-pushed
the
move-to-java-storage-update-items
branch
from
22bf404
to
7d5780e
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.