Add java-storage implementation for get buckets and object methods. #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilpi23pandey
force-pushed
the
move-to-java-storage-get-info
branch
4 times, most recently
from
ca8fb72
to
a008e09
Compare
|
/gcbrun |
shilpi23pandey
force-pushed
the
move-to-java-storage-get-info
branch
2 times, most recently
from
ca026c4
to
b7dbda6
Compare
|
/gcbrun |
shilpi23pandey
force-pushed
the
move-to-java-storage-get-info
branch
2 times, most recently
from
4a90385
to
61d196b
Compare
|
/gcbrun |
shilpi23pandey
force-pushed
the
move-to-java-storage-get-info
branch
from
61d196b
to
b118ae1
Compare
|
/gcbrun |
| return new ArrayList<>(); | ||
| } | ||
|
|
||
| Map<StorageResourceId, GoogleCloudStorageItemInfo> itemInfos = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
nit: we can consider setting the capacity since it is known.
| "Somehow missing resourceId '%s' from map: %s", | ||
| resourceId, | ||
| itemInfos); | ||
| sortedItemInfos.add(itemInfos.get(resourceId)); |
There was a problem hiding this comment.
What will happen if getting this resourceId failed? it will not be present in the map, correct?
There was a problem hiding this comment.
In cases where fetching the resource failed, the exceptions will be added as part of innerExceptions https://github.com/GoogleCloudDataproc/hadoop-connectors/pull/1089/files/b118ae14967f9a6299f10c87e6b8ee24b17787ec#diff-23a518b24b3819c111aacec5ec168906787ef291585a52e128c1ce776b8ed0fbR601 and these lines wont be executed.
shilpi23pandey
force-pushed
the
move-to-java-storage-get-info
branch
from
b118ae1
to
b5080d8
Compare
|
/gcbrun |
shilpi23pandey
force-pushed
the
move-to-java-storage-get-info
branch
from
b5080d8
to
9c5da9f
Compare
|
/gcbrun |
arunkumarchacko
approved these changes
Jan 5, 2024
| // Blob field that are used in GoogleCloudStorageItemInfo. | ||
| static final List<BlobField> BLOB_FIELDS = | ||
| ImmutableList.of( | ||
| BlobField.BUCKET, |
There was a problem hiding this comment.
Nit: Consider keeping this sorted.
|
/gcbrun |
shilpi23pandey
force-pushed
the
move-to-java-storage-get-info
branch
from
1dbc1ea
to
d0b3cd4
Compare
shilpi23pandey
force-pushed
the
move-to-java-storage-get-info
branch
from
d0b3cd4
to
864a686
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.