Move list bucket methods to java-storage. #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilpi23pandey
force-pushed
the
move-to-java-storage-buckets
branch
from
1a9cac7
to
22b2569
Compare
|
/gcbrun |
shilpi23pandey
force-pushed
the
move-to-java-storage-buckets
branch
from
22b2569
to
8459bbc
Compare
shilpi23pandey
force-pushed
the
move-to-java-storage-buckets
branch
from
8459bbc
to
c938fba
Compare
shilpi23pandey
force-pushed
the
move-to-java-storage-buckets
branch
from
c938fba
to
b3c85ad
Compare
| checkNotNull(storageOptions.getProjectId(), "projectId must not be null"); | ||
| List<Bucket> allBuckets = new ArrayList<>(); | ||
| try { | ||
| Page<Bucket> buckets = |
There was a problem hiding this comment.
can there be more than one page or is it taken care of by the iterator?
There was a problem hiding this comment.
The iterator takes care of it. It lazily fetches another page if the current page items are exhausted. https://github.com/googleapis/java-storage/blob/main/samples/snippets/src/main/java/com/example/storage/bucket/ListBuckets.java https://cloud.google.com/java/docs/reference/gax/latest/com.google.api.gax.paging.Page.html#com_google_api_gax_paging_Page_iterateAll__
| try { | ||
| Page<Bucket> buckets = | ||
| storage.list( | ||
| BucketListOption.pageSize(storageOptions.getMaxListItemsPerCall()), |
There was a problem hiding this comment.
What is the max allowed?
There was a problem hiding this comment.
1000 for bucket fields without acl and 200 with acl. We use non-acl fields so it is 1000 for this use case.
arunkumarchacko
approved these changes
Dec 7, 2023
|
/gcbrun |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.