Increase threshold (#1167)

* Throwing read exception instead of absorbing (#1157) * Adding random read throughput (#1148) (cherry picked from commit f39c78f) * Throwing exception from read * Throwing exception from read * Adding Integration test in place of UT * Formatting * attempt on UT * Changing signature of channel * modifying UT * removing changes * modifying test name * modifying test name * Addressing comments * Removing HN changes * Increasing threshold
GoogleCloudDataproc · Jun 12, 2024 · 9bbff28 · 9bbff28
1 parent 69afffc
commit 9bbff28
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/GhfsGlobalStorageStatistics.java b/gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/GhfsGlobalStorageStatistics.java
@@ -59,7 +59,7 @@ public class GhfsGlobalStorageStatistics extends StorageStatistics {
   /** {@value} The key that stores all the registered metrics */
   public static final String NAME = "GhfsStorageStatistics";
 
-  public static final int LATENCY_LOGGING_THRESHOLD_MS = 300;
+  public static final int LATENCY_LOGGING_THRESHOLD_MS = 500;
 
   // Instance to be used if it encounters any error while registering to Global Statistics.
   // Error can happen for e.g. when different class loaders are used.
@@ -101,7 +101,7 @@ static <B> B trackDuration(
       throws IOException {
     Stopwatch stopwatch = Stopwatch.createStarted();
 
-    try (ITraceOperation op_fs =
+    try (ITraceOperation opFS =
         traceFactory.createRootWithLogging(statistic.getSymbol(), context)) {
       stats.increment(statistic);
       return IOStatisticsBinding.trackDuration(factory, statistic.getSymbol(), operation);

diff --git a/gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/GoogleHadoopFSInputStream.java b/gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/GoogleHadoopFSInputStream.java
@@ -313,7 +313,7 @@ public synchronized void close() throws IOException {
    * {@code ThreadTrace}.
    */
   private <B> B trackDurationWithTracing(
-      DurationTrackerFactory factory1,
+      DurationTrackerFactory durationTracker,
       @Nonnull GhfsGlobalStorageStatistics stats,
       GhfsStatistic statistic,
       Object context,
@@ -322,7 +322,7 @@ private <B> B trackDurationWithTracing(
       throws IOException {
 
     return GhfsGlobalStorageStatistics.trackDuration(
-        factory1, stats, statistic, context, traceFactory, operation);
+        durationTracker, stats, statistic, context, traceFactory, operation);
   }
 
   /**