Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example image coding in Page Template #196

Closed
JillTunick opened this issue Jun 24, 2022 · 2 comments
Closed

Fix example image coding in Page Template #196

JillTunick opened this issue Jun 24, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@JillTunick
Copy link
Contributor

JillTunick commented Jun 24, 2022

https://github.com/GSA/idmanagement.gov/blob/staging/page-template.md

Users access this page by clicking the Page Template hyperlink in the Help Us Improve Our Content page (https://www.idmanagement.gov/contribute/)

To find the page in GitHub, scroll to the bottom of the IDM.gov repository landing page. The file, page-template.md, is a standalone file at the very bottom of the IDM.gov list of collections and files.

The example image hyperlinks in lines 118 through 122 of the page template are in an old, outdated format. Put them in this format:

<img src="{{site.baseurl}}/assets/piv/pivauth-untrusted-ca-logon-screen.png" alt="A screenshot of a logon window that includes the words An untrusted certification authority was detected while processing the smart card certificate used for authentication." width="664" height="448">

There is also a page-template.md file in the FICAM Playbooks repository. You may have to fix the example image links on that page, too. After you fix the example image coding in the page-template.md file in the IDM.gov repository, submit a pull request, and the updated content is published, check the page-template.md file in the FICAM Playbooks repository to see if your changes are already there. They may port over or they might not; I'm not sure if they will. If your changes haven't ported over from the page-template.md file you fixed in the IDM.gov repository, create a separate issue to fix the page-template.md file in the FICAM Playbooks repository.

@JillTunick JillTunick added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jun 24, 2022
itsmohitchahal added a commit to itsmohitchahal/idmanagement.gov that referenced this issue Jun 24, 2022
@itsmohitchahal
Copy link
Contributor

@JillTunick Made a pull request for this in the idmanagement.gov repository. Please check

@JillTunick
Copy link
Contributor Author

JillTunick commented Jun 28, 2022 via email

idmken added a commit that referenced this issue Jun 29, 2022
Updated page-template.md as per Issue #196
@idmken idmken closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
3 participants