Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Fixed Size Binary Type v2 #2403

Merged
merged 11 commits into from
Jun 19, 2024
Merged

[FEAT] Fixed Size Binary Type v2 #2403

merged 11 commits into from
Jun 19, 2024

Conversation

Vince7778
Copy link
Contributor

Supersedes #2266. Additionally implements binary to fixed_size_binary cast if all values have the correct length.

Original description:

Implements a fixed size binary type and array.

Todo:

  • Optimize the kernels to leverage fixed size lengths
@Vince7778 Vince7778 changed the title Fixed Size Binary Type v2 Jun 19, 2024
@github-actions github-actions bot added the enhancement New feature or request label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 63.14879% with 213 lines in your changes missing coverage. Please review.

Project coverage is 63.14%. Comparing base (0f748ed) to head (b146f30).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
+ Coverage   62.93%   63.14%   +0.21%     
==========================================
  Files         938      938              
  Lines      104652   105253     +601     
==========================================
+ Hits        65858    66458     +600     
- Misses      38794    38795       +1     
Files Coverage Δ
src/daft-core/src/array/from.rs 87.12% <100.00%> (+0.83%) ⬆️
src/daft-core/src/array/from_iter.rs 100.00% <100.00%> (ø)
src/daft-core/src/array/growable/arrow_growable.rs 100.00% <ø> (ø)
src/daft-core/src/array/growable/mod.rs 100.00% <ø> (ø)
src/daft-core/src/array/ops/as_arrow.rs 100.00% <ø> (ø)
src/daft-core/src/array/ops/get.rs 81.50% <ø> (ø)
src/daft-core/src/array/ops/groups.rs 98.03% <100.00%> (+0.12%) ⬆️
src/daft-core/src/array/ops/is_in.rs 100.00% <ø> (ø)
src/daft-core/src/array/ops/repr.rs 68.98% <100.00%> (+0.88%) ⬆️
src/daft-core/src/array/ops/take.rs 99.44% <100.00%> (+0.08%) ⬆️
... and 24 more

... and 17 files with indirect coverage changes

Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casting logic looks good overall, just a couple of comments

src/arrow2/src/compute/cast/binary_to.rs Outdated Show resolved Hide resolved
tests/series/test_cast.py Outdated Show resolved Hide resolved
tests/series/test_cast.py Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vince7778 Vince7778 merged commit a8876f0 into main Jun 19, 2024
45 checks passed
@Vince7778 Vince7778 deleted the conor/fixedsizebinary branch June 19, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants