Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] [New Executor] [1/N] Move physical plan scheduler to new crate, misc. refactorings + drive-bys for new executor #2339

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[FEAT] [New Executor] [1/N] Move physical plan scheduler to new crate, misc. refactorings + drive-bys for new executor #2339

merged 2 commits into from
Jun 5, 2024

Conversation

clarkzinzow
Copy link
Contributor

@clarkzinzow clarkzinzow commented Jun 5, 2024 •
edited
Loading

This PR moves the physical plan scheduler to a new daft-scheduling crate in order to avoid cycle dependencies for the new executor, which depends on daft-plan. New dependency tree will be:

daft-plan   <--  daft-execution
       ^            ^
        \          /
      daft-scheduling

This PR also contains misc. refactorings and drive-bys for follow-up new executor PRs, and will be the bottom of a stack of PRs.
@github-actions github-actions bot added the enhancement New feature or request label Jun 5, 2024
@clarkzinzow clarkzinzow mentioned this pull request Jun 5, 2024
Merged
2 tasks
samster25
samster25 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nothing controversial about the changes here!
src/daft-scheduler/Cargo.toml Outdated Show resolved Hide resolved
@clarkzinzow clarkzinzow merged commit 8a789be into main Jun 5, 2024
42 checks passed
@clarkzinzow clarkzinzow deleted the clark/execution-model-prototype-1-refactor branch June 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants
@clarkzinzow @samster25