Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Sign expression implemtation #2037

Merged
merged 8 commits into from
Mar 25, 2024

Conversation

sherlockbeard
Copy link
Contributor

implementation for sign resolves #1917

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (afd6a75) to head (cd8ed01).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2037      +/-   ##
==========================================
- Coverage   84.74%   84.70%   -0.05%     
==========================================
  Files          62       62              
  Lines        6803     6811       +8     
==========================================
+ Hits         5765     5769       +4     
- Misses       1038     1042       +4     
Files Coverage Δ
daft/expressions/expressions.py 91.57% <100.00%> (+0.05%) ⬆️
daft/series.py 93.16% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

@samster25 samster25 added the enhancement New feature or request label Mar 25, 2024
@samster25 samster25 requested a review from colin-ho March 25, 2024 04:34
@samster25
Copy link
Member

Thanks @sherlockbeard for taking this on!
@colin-ho Can you take a look?

daft/expressions/expressions.py Outdated Show resolved Hide resolved
src/daft-core/src/series/ops/sign.rs Outdated Show resolved Hide resolved
@colin-ho
Copy link
Contributor

Thanks @sherlockbeard for taking this on! @colin-ho Can you take a look?

Thanks @sherlockbeard for this PR! Just left a few comments :)

@colin-ho
Copy link
Contributor

Awesome stuff @sherlockbeard!! Thanks for this contribution :)

@colin-ho colin-ho merged commit b43c3c8 into Eventual-Inc:main Mar 25, 2024
29 checks passed
@jaychia
Copy link
Contributor

jaychia commented Mar 25, 2024

Congrats on your first PR @sherlockbeard !! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
4 participants