[FEAT] Add str.left() funtion #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2027 +/- ##
==========================================
+ Coverage 84.70% 84.71% +0.01%
==========================================
Files 62 62
Lines 6768 6779 +11
==========================================
+ Hits 5733 5743 +10
- Misses 1035 1036 +1
|
murex971
force-pushed
the
murex/str-left
branch
from
1ff66c6
to
2a3f7a5
Compare
colin-ho
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Hey @murex971, aweome work! In addition to the comments I left, could you also add a test in tests/table/utf8 similar to this one https://github.com/Eventual-Inc/Daft/blob/main/tests/table/utf8/test_match.py. Thanks :)
murex971
force-pushed
the
murex/str-left
branch
from
38f0dc7
to
a645e34
Compare
|
@colin-ho pushed the changes. |
colin-ho
reviewed
Mar 21, 2024
|
@colin-ho thanks for the review. Addressed. |
colin-ho
approved these changes
Mar 21, 2024
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns the left-most n characters
Resolves #1926