[CHORE] Add global aggregation docs and error on improper aggregation usage #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2025 +/- ##
==========================================
+ Coverage 82.71% 84.69% +1.98%
==========================================
Files 62 62
Lines 6623 6771 +148
==========================================
+ Hits 5478 5735 +257
+ Misses 1145 1036 -109
|
colin-ho
approved these changes
Mar 20, 2024
daft/dataframe/dataframe.py
Outdated
| Args: | ||
| *cols (Union[str, Expression]): columns to get an arbitrary value from | ||
| Returns: | ||
| DataFrame: Globally aggregated max. Should be a single row. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added API docs for global expressions.
Also, the builder now checks if there are any aggregation expressions outside of the top level of an agg call, and errors if there are. This effectively disables nested aggs for now